Narrow four utf16 chars to ascii and write to buffer #39508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to split up my single PR into multiple ones so I can isolate CI bugs better. I believe this change should be good to go in.
In the process of splitting, I eventually found that the ARM64 CI legs seem to be broken currently. I opened #39582 to test that claim.
Perf results:
Before and After Arm64 optimizations
calope@calopearm:~/performance/src/tools/ResultsComparer$ dotnet run --base ~/pgovind_before/ --diff ~/pgovind_after/ --threshold 0.01%
summary:
better: 1, geomean: 1.244
total diff: 1
No Slower results for the provided threshold = 0.01% and noise filter = 0.3ns.