WASM: Enable System.Reflection.* tests #39696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable tests that won't work on browser.
akoeplinger
changed the title
ViktorHofer
reviewed
Jul 21, 2020
| <WasmFilesToIncludeInFileSystem Include="$(PublishDir)System.Reflection.Metadata.Tests.dll" /> | ||
| </ItemGroup> | ||
| <ItemGroup Condition="'$(AssemblyName)' == 'System.Reflection.Tests'"> | ||
| <WasmFilesToIncludeInFileSystem Include="$(PublishDir)System.Reflection.Tests.dll" /> |
There was a problem hiding this comment.
is there a better way to track these dependencies? hardcoding looks wrong
There was a problem hiding this comment.
Or avoid defining this centrally and instead set a property in the project file that indicates this?
There was a problem hiding this comment.
yeah we need to find a better way.
There was a problem hiding this comment.
Can you please open an issue to discuss this?
There was a problem hiding this comment.
I think the project could add to an item and then we could transform that item to remap the value to be under PublishDir
ViktorHofer
approved these changes
Jul 21, 2020
99 tasks
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
Disable tests that won't work on browser.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable tests that won't work on browser.