Use lib prefix for native library names for consistency #39717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @safern, @ViktorHofer |
jkotas
commented
Jul 21, 2020
| @@ -6,6 +6,6 @@ internal static partial class Interop | |||
| internal static partial class Libraries | |||
| { | |||
| internal const string Odbc32 = "libodbc.so.2"; | |||
| internal const string MsQuic = "msquic"; | |||
| internal const string MsQuic = "libmsquic.so"; | |||
There was a problem hiding this comment.
I have fixed up msquic just for consistency
ViktorHofer
approved these changes
Jul 21, 2020
|
The loader has fallback that tries multiple library names with different prefixes / suffixes. It is what made it work. |
|
It was discovered in CoreRT dotnet/corert#8241 since the native AOT is more sensitive to details like this. |
safern
approved these changes
Jul 21, 2020
|
Should/can we add some validation for the names of native libraries we produce on Unix to make sure they all have |
|
I would expect that codereviews would be good enough to catch wrong native library name if we add more of them. |
akoeplinger
reviewed
Jul 21, 2020
akoeplinger
requested changes
Jul 21, 2020
akoeplinger
approved these changes
Jul 22, 2020
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#33236 added lib prefix to the native libraries, but it was missed in number of places.