[browser][file system] Tests System.IO.FileSystem

[kjpou1]

Added 45 [PlatformSpecific(~TestPlatforms.Browser)] checks to tests.

 info: test[0]
        Tests run: 3804, Errors: 0, Failures: 0, Skipped: 100. Time: 37.597637s

// IO.Pipes not supported
public void FlushCanBeUsedOnPipes_Success(bool? flushToDisk)
public void CanSeekReturnsFalseForPipe()
public async Task AnonymousPipeReadViaFileStream(bool asyncReads)
public async Task AnonymousPipeWriteViaFileStream(bool asyncWrites)
public async Task AnonymousPipeViaFileStream_AllDataCopied(int writeSize, int numWrites)

// System.PlatformNotSupportedException : Cannot wait on monitors on this runtime.
public void EmptyFile_Read_Succeeds()
public void NonEmptyFile_Read_GetsExpectedData()
public void NonEmptyWrite_WritesExpectedData()
public Task ManyConcurrentWriteAsyncs()

• Directory.CreateDirectory.cs

  • Browser platform volume does not limit each component of the path to a total of 255 characters.
  • Remove the test DirectoryWithComponentLongerThanMaxComponentAsPath_ThrowsException for Browser platform.
  • Add new test DirectoryWithComponentLongerThanMaxComponentAsPath_BrowserDoesNotThrowsException for Browser platform in case this check is added in the future.

Error number: #39955 - Resolved

File locking not supported: #40065

System.IO.FileSystem/tests/File/ReadWriteAllBytes.cs
        [ActiveIssue("https://github.com/dotnet/runtime/issues/40065", TestPlatforms.Browser)]
         public void OpenFile_ThrowsIOException()

System.IO.FileSystem/tests/File/ReadWriteAllBytesAsync.cs
        [ActiveIssue("https://github.com/dotnet/runtime/issues/40065", TestPlatforms.Browser)]
         public async Task OpenFile_ThrowsIOExceptionAsync()

System.IO.FileSystem/tests/File/ReadWriteAllLines.cs
        [ActiveIssue("https://github.com/dotnet/runtime/issues/40065", TestPlatforms.Browser)]
         public void OpenFile_ThrowsIOException()

        [ActiveIssue("https://github.com/dotnet/runtime/issues/40065", TestPlatforms.Browser)]
         public void OpenFile_ThrowsIOException()

System.IO.FileSystem/tests/File/ReadWriteAllLinesAsync.cs
        [ActiveIssue("https://github.com/dotnet/runtime/issues/40065", TestPlatforms.Browser)]
         public async Task OpenFile_ThrowsIOExceptionAsync()

System.IO.FileSystem/tests/File/ReadWriteAllText.cs
        [ActiveIssue("https://github.com/dotnet/runtime/issues/40065", TestPlatforms.Browser)]
         public void OpenFile_ThrowsIOException()

System.IO.FileSystem/tests/File/ReadWriteAllTextAsync.cs
        [ActiveIssue("https://github.com/dotnet/runtime/issues/40065", TestPlatforms.Browser)]
         public async Task OpenFile_ThrowsIOExceptionAsync()

System.IO.FileSystem/tests/File/Create.cs
        [ActiveIssue("https://github.com/dotnet/runtime/issues/40065", TestPlatforms.Browser)]
         public void FileInUse()

System.IO.FileSystem/tests/FileStream/ctor_str_fm_fa_fs.cs
        [ActiveIssue("https://github.com/dotnet/runtime/issues/40065", TestPlatforms.Browser)]
         public void NoTruncateOnFileShareViolation(FileMode fileMode)

System.IO.FileSystem/tests/FileStream/ctor_str_fm_fa_fs.write.cs
        [ActiveIssue("https://github.com/dotnet/runtime/issues/40065", TestPlatforms.Browser)]
         public void FileShareWithoutWriteThrows()

A FIFO special file is similar to a pipe, except that it is created in a different way. Instead of being an anonymous communications channel, a FIFO special file is entered into the file system by calling mkfifo(). Pipes are not supported on WebAssembly. Platform specific skip for browser in the following tests.

System.IO.FileSystem/tests/DirectoryInfo/Exists.cs
        public void FalseForNonRegularFile()

System.IO.FileSystem/tests/Directory/Exists.cs
        public void FalseForNonRegularFile()

System.IO.FileSystem/tests/FileInfo/Exists.cs
        public void TrueForNonRegularFile()

System.IO.FileSystem/tests/File/Exists.cs
        public void FalseForNonRegularFile()

File rename issue reporting wrong error: #40305
PR #40310 works around the issue for now while waiting for fix emscripten-core/emscripten#11804 / emscripten-core/emscripten#11812

Depends on PR: #39763 - merged

[steveisok]

What do you think about returning 0 here and eliminating the platform checks?

[kjpou1]

By doing that and modifying the places that use geteuid the tests fail with:

[FAIL] System.IO.Tests.File_AppendAllLinesAsync.WriteToReadOnlyFile
        
  �[40m�[37mdbug�[39m�[22m�[49m: test[0]
        System.UnauthorizedAccessException : Access to the path '/tmp/File_AppendAllLinesAsync_mqajhnoo.uqp/WriteToReadOnlyFile_105_93d848c1' is denied.
        
  �[40m�[37mdbug�[39m�[22m�[49m: test[0]
        ---- System.IO.IOException : Permission denied

[steveisok]

The pal uses sendFile and emscripten's implementation doesn't seem too friendly w/ read only files. The error message refers to not being able to write to the destination file.

If you skip this block

runtime/src/libraries/Native/Unix/System.Native/pal_io.c

Lines 1152 to 1191 in 05f17e3

	#if HAVE_SENDFILE_4
	// On 32-bit, if you use 64-bit offsets, the last argument of `sendfile' will be a
	// `size_t' a 32-bit integer while the `st_size' field of the stat structure will be off64_t.
	// So `size' will have to be `uint64_t'. In all other cases, it will be `size_t'.
	uint64_t size = (uint64_t)sourceStat.st_size;
	// Note that per man page for large files, you have to iterate until the
	// whole file is copied (Linux has a limit of 0x7ffff000 bytes copied).
	while (size > 0)
	{
	ssize_t sent = sendfile(outFd, inFd, NULL, (size >= SSIZE_MAX ? SSIZE_MAX : (size_t)size));
	if (sent < 0)
	{
	if (errno != EINVAL && errno != ENOSYS)
	{
	tmpErrno = errno;
	close(outFd);
	errno = tmpErrno;
	return -1;
	}
	else
	{
	break;
	}
	}
	else
	{
	assert((size_t)sent <= size);
	size -= (size_t)sent;
	}
	}
	if (size == 0)
	{
	copied = true;
	}
	// sendfile couldn't be used; fall back to a manual copy below. This could happen
	// if we're on an old kernel, for example, where sendfile could only be used
	// with sockets and not regular files.
	#endif // HAVE_SENDFILE_4

, I think copying will work.

[kjpou1]

I have gone through the build and it looks like this code block is already being skipped in the native pal.

[steveisok]

You're right. I was looking at the wrong place thinking it was included.

We should trace to see what call is bad.

[kjpou1]

agreed

[MaximLipnin]

You also need to remove the test suite from src/libraries/tests.proj:
https://github.com/dotnet/runtime/blob/master/src/libraries/tests.proj#L32

[jkotas]

Same question here

[kjpou1]

You also need to remove the test suite from src/libraries/tests.proj:
https://github.com/dotnet/runtime/blob/master/src/libraries/tests.proj#L32

Thanks Maxim was just waiting for PR #39763 because it would have failed anyway

[mdh1418]

There were a few places in System.IO.MemoryMappedFiles that also had (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && PlatformDetection.IsSuperUser), since we are changing IsSuperUser to return false rather than throwing here, should those two instances in MemoryMappedFiles.CreateFromFile.Tests.cs L700 and L706 be changed in this PR as well? If we don't want to mix suites, I can just put up another PR after this gets merged.

[kjpou1]

@mdh1418

There were a few places in System.IO.MemoryMappedFiles that also had (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && PlatformDetection.IsSuperUser), since we are changing IsSuperUser to return false rather than throwing here, should those two instances in MemoryMappedFiles.CreateFromFile.Tests.cs L700 and L706 be changed in this PR as well? If we don't want to mix suites, I can just put up another PR after this gets merged.

Could you check the files that are in the PR. I thought I got all of them.

[mdh1418]

Currently the results are: Tests run: 3903, Errors: 0, Failures: 0, Skipped: 117. Time: 10.340306s

[MaximLipnin]

lgtm, just a couple of minor comments