Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable on mono: Microsoft.Extensions.Http.Factory_CleanupCycle_DisposesEligibleHandler #39784

Merged
1 commit merged into from
Jul 22, 2020
Merged

Disable on mono: Microsoft.Extensions.Http.Factory_CleanupCycle_DisposesEligibleHandler #39784

1 commit merged into from
Jul 22, 2020

Conversation

maryamariyan
Copy link
Member 

Cleanup entry disposable\nExpected: True\nActual:   False
   at Microsoft.Extensions.Http.DefaultHttpClientFactoryTest.Factory_CleanupCycle_DisposesEligibleHandler() in /_/src/libraries/Microsoft.Extensions.Http/tests/DefaultHttpClientFactoryTest.cs:line 378
--- End of stack trace from previous location ---

Related to: #34023

@maryamariyan
MEH test failure on mono
66652a1 
Factory_CleanupCycle_DisposesEligibleHandler
@maryamariyan maryamariyan self-assigned this Jul 22, 2020
@ghost
Copy link

ghost commented Jul 22, 2020

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

@ghost
Copy link

ghost commented Jul 22, 2020

Tagging subscribers to this area: @maryamariyan
Notify danmosemsft if you want to be subscribed.

wfurt
wfurt approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link

ghost commented Jul 22, 2020

Hello @maryamariyan!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit ffe0ab1 into dotnet:master Jul 22, 2020
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@maryamariyan @Jacksondr5
MEH test failure on mono (dotnet#39784)
890fe15 
Factory_CleanupCycle_DisposesEligibleHandler
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wfurt wfurt wfurt approved these changes

Assignees

@maryamariyan maryamariyan

Labels
area-Extensions-HttpClientFactory
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@maryamariyan @wfurt @karelz @Dotnet-GitSync-Bot