Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM: Enable Invariant.Tests #39814

Merged
merged 2 commits into from
Jul 23, 2020
Merged

WASM: Enable Invariant.Tests #39814

merged 2 commits into from
Jul 23, 2020

Conversation

safern
Copy link
Member

@safern safern commented Jul 23, 2020

Contributes towards: #38422

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@safern
Copy link
Member Author

safern commented Jul 23, 2020

Alright, Browser leg is now green.

@SamMonoRT
Copy link
Member

SamMonoRT commented Jul 23, 2020

@safern @naricc trying to understand why we don't see the Interpreter lanes for runtime tests, we do see the other Mono Prio0 runtime test lanes for jit though

@ghost
Copy link

ghost commented Jul 23, 2020

Tagging subscribers to this area: @tarekgh, @safern, @krwq
See info in area-owners.md if you want to be subscribed.

@safern
Copy link
Member Author

safern commented Jul 23, 2020

It is because in order to optimize resources and avoid dedicating a machine to invoke helix to run the interpreter tests and one for non-interpreter tests, we use the same lane for both and just send to helix jobs with different environment variable settings.

 Starting Azure Pipelines Test Run Mono Linux arm64 Release @ (Ubuntu.1804.Arm64.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm64v8-a45aeeb-20190620155855
  Starting Azure Pipelines Test Run Mono Linux arm64 Release interpreter @ (Ubuntu.1804.Arm64.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm64v8-a45aeeb-20190620155855

You can find that under:
Mono Pri0 Runtime Tests Run Linux arm64 release

In Send to helix step.

So basically on the same lane we run both, JIT and interpreter by creating multiple Helix jobs. Which results in using less machines for our build 😄

@naricc
Copy link
Contributor

naricc commented Jul 23, 2020

@SamMonoRT

@safern @naricc trying to understand why we don't see the Interpreter lanes for runtime tests, we do see the other Mono Prio0 runtime test lanes for jit though

We moved the interpreter to be a scenario instead of a seperate lane. So the interpreter is running, along with the jit, as part of this one "Mono Common Pri0 Test Build AnyOS AnyCPU release". I just double checked to verify it is still running the interpreter.

@safern
Copy link
Member Author

safern commented Jul 23, 2020

Badges didn't update, build is green.

@safern safern merged commit df35f26 into dotnet:master Jul 23, 2020
@safern safern deleted the wasm-invarianttests branch July 23, 2020 23:21
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
* WASM: Enable Invariant.Tests

* Fix build and PR Feedback
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants