Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Perf Helix Workitem #39859

Merged
merged 11 commits into from
Jul 29, 2020
Merged

Split Perf Helix Workitem #39859

merged 11 commits into from
Jul 29, 2020

Conversation

ooooolivia
Copy link
Contributor

@ooooolivia ooooolivia commented Jul 23, 2020 •
edited
Loading

  • update crossgen perf job runkind to crossgen_scenarios
  • split perf jobs based on runkind in perf_job.yml

@ooooolivia ooooolivia marked this pull request as draft July 23, 2020 19:34
@jaredpar jaredpar mentioned this pull request Jul 24, 2020
Closed
@ooooolivia ooooolivia changed the title Crossgen proj Split Perf Helix Workitem Jul 24, 2020
@ooooolivia ooooolivia marked this pull request as ready for review July 27, 2020 17:20
@ooooolivia
Copy link
Contributor Author

@billwert @DrewScoggins Can you review this? tagging here as there's no inviting review feature accessible for me

DrewScoggins
DrewScoggins reviewed Jul 28, 2020
View reviewed changes
Copy link
Member

@DrewScoggins DrewScoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding all of these comments as well.

eng/pipelines/coreclr/perf.yml Outdated Show resolved Hide resolved
eng/pipelines/coreclr/perf.yml Outdated Show resolved Hide resolved
eng/common/templates/steps/perf-send-to-helix.yml Outdated Show resolved Hide resolved
@ooooolivia
Copy link
Contributor Author

ooooolivia commented Jul 28, 2020 •
edited
Loading

PR merged for fixing format issue: #40035
PR merged for fixing HTTP functional test issue: #40015

@ooooolivia
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@ooooolivia
Copy link
Contributor Author

/azp run dotnet-runtime-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DrewScoggins
Copy link
Member

Once those checks pass on re-run LGTM.

@DrewScoggins DrewScoggins self-requested a review July 29, 2020 16:42
@ooooolivia ooooolivia merged commit 38c9792 into dotnet:master Jul 29, 2020
@ooooolivia ooooolivia mentioned this pull request Jul 29, 2020
Merged
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@ooooolivia @Jacksondr5
Split Perf Helix Workitem (dotnet#39859)
eb36558 
* wip

* split perf jobs into test categories

* add test category to run-performance-job.yml

* correct space

* add space to parameter var

* add $

* fix yaml

* revert extraparameters

* replace crossgen runkind

* change micro_mono tag

* remove space
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DrewScoggins DrewScoggins DrewScoggins approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ooooolivia @DrewScoggins @karelz @Dotnet-GitSync-Bot