Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GC Poll inlining. #39881

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Fix GC Poll inlining. #39881

merged 1 commit into from
Jul 24, 2020

Conversation

erozenfeld
Copy link
Member

  • Don't inline GC polls in cold basic blocks.
  • Allow GC poll inlining in basic blocks with BBF_LOOP_PREHEADER or BBF_RETLESS_CALL set.

This fixes one of the assert seen in #39474 (comment)

Contributes to resolving #39726.

@erozenfeld
Fix GC Poll inlining.
8017e30 
* Don't inline GC polls in cold basic blocks.
* Allow GC poll inlining in basic blocks with `BBF_LOOP_PREHEADER` or `BBF_RETLESS_CALL` set.

This fixes one of the assert seen in dotnet#39474 (comment)

Contributes to resolving dotnet#39726.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 24, 2020
@erozenfeld
Copy link
Member Author

@briansull @AndyAyersMS @dotnet/jit-contrib PTAL

@erozenfeld erozenfeld mentioned this pull request Jul 24, 2020
Closed
2 tasks
@erozenfeld
Copy link
Member Author

@dotnet/jit-contrib ping

@erozenfeld erozenfeld merged commit 3665779 into dotnet:master Jul 24, 2020
@erozenfeld erozenfeld mentioned this pull request Jul 25, 2020
Closed
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@erozenfeld @Jacksondr5
Fix GC Poll inlining. (dotnet#39881)
0c45c49 
* Don't inline GC polls in cold basic blocks.
* Allow GC poll inlining in basic blocks with `BBF_LOOP_PREHEADER` or `BBF_RETLESS_CALL` set.

This fixes one of the assert seen in dotnet#39474 (comment)

Contributes to resolving dotnet#39726.
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

@briansull briansull Awaiting requested review from briansull

@AndyAyersMS AndyAyersMS Awaiting requested review from AndyAyersMS

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@erozenfeld @BruceForstall @karelz @Dotnet-GitSync-Bot