Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Re-enable some tests in the System.Net.WebSockets.Tests namespace #40004

Merged
merged 2 commits into from
Jul 29, 2020
Merged

[wasm] Re-enable some tests in the System.Net.WebSockets.Tests namespace #40004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28fe097
[wasm] Re-enable some tests in the System.Net.WebSockets.Tests namespace
MaximLipnin Jul 28, 2020
2f2915a
[wasm] Re-enable System.Net.WebSockets.Tests.WebSocketProtocolCreateT…
MaximLipnin Jul 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/libraries/Common/tests/System/Net/WebSockets/WebSocketCreateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ public async Task ReceiveAsync_UTF8SplitAcrossMultipleBuffers_ValidDataReceived(
}

[Theory]
[PlatformSpecific(~TestPlatforms.Browser)] // System.Net.Sockets is not supported on this platform.
[ActiveIssue("https://github.com/dotnet/runtime/issues/34690", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[InlineData(0b_1000_0001, 0b_0_000_0001, false)] // fin + text, no mask + length == 1
[InlineData(0b_1100_0001, 0b_0_000_0001, true)] // fin + rsv1 + text, no mask + length == 1
Expand Down Expand Up @@ -147,6 +148,7 @@ public async Task ReceiveAsync_InvalidFrameHeader_AbortsAndThrowsException(byte
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)] // System.Net.Sockets is not supported on this platform.
[ActiveIssue("https://github.com/dotnet/runtime/issues/34690", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
public async Task ReceiveAsync_ServerSplitHeader_ValidDataReceived()
{
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Net.WebSockets.WebSocketProtocol/tests/WebSocketProtocolTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

namespace System.Net.WebSockets.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/38807", TestPlatforms.Browser)]
public sealed class WebSocketProtocolCreateTests : WebSocketCreateTest
{
protected override WebSocket CreateFromStream(Stream stream, bool isServer, string subProtocol, TimeSpan keepAliveInterval) =>
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Net.WebSockets/tests/WebSocketTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

namespace System.Net.WebSockets.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/38807", TestPlatforms.Browser)]
public sealed class WebSocketTests : WebSocketCreateTest
{
protected override WebSocket CreateFromStream(Stream stream, bool isServer, string subProtocol, TimeSpan keepAliveInterval) =>
Expand Down