-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unsafe.IsNullRef and Unsafe.NullRef #40008
Add Unsafe.IsNullRef and Unsafe.NullRef #40008
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
...braries/System.Runtime.CompilerServices.Unsafe/src/System.Runtime.CompilerServices.Unsafe.il
Show resolved
Hide resolved
src/libraries/System.Runtime.CompilerServices.Unsafe/tests/UnsafeTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Adeel Mujahid <adeelbm@outlook.com>
src/libraries/System.Runtime.CompilerServices.Unsafe/tests/UnsafeTests.cs
Outdated
Show resolved
Hide resolved
...raries/System.Runtime.CompilerServices.Unsafe/src/System.Runtime.CompilerServices.Unsafe.xml
Outdated
Show resolved
Hide resolved
...raries/System.Runtime.CompilerServices.Unsafe/src/System.Runtime.CompilerServices.Unsafe.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Happy to help! Looking forward to the public release with these new APIs! 😊🎉 |
@jkotas @marek-safar Any idea why the mono tests might be segfaulting? |
Looks like Jan already beat me to spinning CI back up. ;) |
Co-authored-by: Adeel Mujahid <adeelbm@outlook.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Closes #31170
This PR adds the following new APIs to the public
Unsafe
class:cc. @jkotas @GrabYourPitchforks @stephentoub