Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating RegionInfo object using names with different casing. #40052

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Jul 28, 2020

Fixes #39991

@ghost
Copy link

ghost commented Jul 28, 2020

Tagging subscribers to this area: @tarekgh, @safern, @krwq
See info in area-owners.md if you want to be subscribed.

@tarekgh tarekgh requested a review from safern July 28, 2020 23:39
@tarekgh
Copy link
Member Author

tarekgh commented Jul 29, 2020

The failures showing in System.Net.Http.WinHttpHandler.Functional.Tests but when looking at the logs, the test looks succeeded.
https://helix.dot.net/api/2019-06-17/jobs/6b514377-c659-427c-892c-d5b30caa1fe9/workitems/System.Net.Http.WinHttpHandler.Functional.Tests/console

@MattGal is this infrastructure known issue?

@safern
Copy link
Member

safern commented Jul 29, 2020

Actually there seems to be 1 test failure but since there are some skipped tests is somewhat hidden:


System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandlerTest.SendAsync_Expect100Continue_RequestBodyFails_ThrowsContentException [FAIL]
      System.Net.Sockets.SocketException : An existing connection was forcibly closed by the remote host.
      Stack Trace:
        /_/src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Tasks.cs(439,0): at System.Net.Sockets.Socket.GetException(SocketError error, Boolean wrapExceptionsInIOExceptions)
        /_/src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Tasks.cs(403,0): at System.Net.Sockets.Socket.CompleteAccept(Socket s, TaskSocketAsyncEventArgs`1 saea)
        /_/src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Tasks.cs(41,0): at System.Net.Sockets.Socket.<>c.<AcceptAsync>b__287_0(Object s, SocketAsyncEventArgs e)
        /_/src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.cs(203,0): at System.Net.Sockets.SocketAsyncEventArgs.OnCompleted(SocketAsyncEventArgs e)
        /_/src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.cs(643,0): at System.Net.Sockets.SocketAsyncEventArgs.FinishOperationAsyncFailure(SocketError socketError, Int32 bytesTransferred, SocketFlags flags)
        /_/src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.Windows.cs(1271,0): at System.Net.Sockets.SocketAsyncEventArgs.HandleCompletionPortCallbackError(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* nativeOverlapped)
        /_/src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.Windows.cs(1233,0): at System.Net.Sockets.SocketAsyncEventArgs.<>c.<.cctor>b__177_0(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* nativeOverlapped)
        /_/src/coreclr/src/System.Private.CoreLib/src/System/Threading/Overlapped.cs(62,0): at System.Threading._IOCompletionCallback.PerformIOCompletionCallback(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* pNativeOverlapped)
...

But seems known/unrelated.

@tarekgh
Copy link
Member Author

tarekgh commented Jul 29, 2020

Good catch @safern. looks I need new glasses :-)

I logged the issue #40057 to track fixing that.

@tarekgh tarekgh merged commit 26b818b into dotnet:master Jul 29, 2020
@tarekgh tarekgh deleted the FixRegionInfoNamesLookup branch July 29, 2020 02:15
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new RegionInfo("NO").NativeName returns different strings depending on the capitalization of the country code
5 participants