Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not test sockets handler fix on WinHttpHandler. #40070

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

ManickaP
Copy link
Member

The fix introduced in #38774 was only for SocketsHttpHandler and the introduced test, specific for the tested scenario, should also be run only on SocketsHttpHandler.

Fixes #40057

@ghost
Copy link

ghost commented Jul 29, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@ManickaP ManickaP requested a review from a team July 29, 2020 09:03
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManickaP ManickaP merged commit 9df596f into dotnet:master Jul 29, 2020
@ManickaP ManickaP deleted the mapichov/40057_fix_test branch July 29, 2020 10:41
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants