Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CoreLib build when building libraries solutions #40097

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Fix CoreLib build when building libraries solutions #40097

merged 1 commit into from
Jul 29, 2020

Conversation

ViktorHofer
Copy link
Member

If a project that is part of solution has a ProjectReference to CoreLib, the Platform property was set to AnyCPU and CoreLib was built with the wrong Platform/Platform_Target.

Fixes #40073

cc @alnikola

@ViktorHofer
Fix CoreLib build when building libraries solutions
10d8f69 
If a project that is part of solution has a ProjectReference to CoreLib, the Platform property was set to AnyCPU and CoreLib was built with the wrong Platform/Platform_Target.
ericstj
ericstj approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems OK. Double check that we don't need to clear the SetPlatform metadata, can't remember if that is something used anywhere.

@ViktorHofer
Copy link
Member Author

Yeah validated that. The output is now identical when building from a solution vs when building the corelib subset.

@jkotas
Copy link
Member

jkotas commented Jul 29, 2020

Would it make sense to print error in System.Private.CoreLib.csproj for AnyCPU Platform?

jkotas
jkotas approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ViktorHofer
Copy link
Member Author

Yes will do that in a follow-up one.

@ViktorHofer ViktorHofer merged commit 90f0c93 into master Jul 29, 2020
@safern safern deleted the ViktorHofer-corelibp2psolution branch July 29, 2020 21:57
safern
safern reviewed Jul 29, 2020
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@ViktorHofer @Jacksondr5
Fix CoreLib build when building libraries solutions (dotnet#40097)
d10e8c3 
If a project that is part of solution has a ProjectReference to CoreLib, the Platform property was set to AnyCPU and CoreLib was built with the wrong Platform/Platform_Target.
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern left review comments

@jkotas jkotas jkotas approved these changes

@ericstj ericstj ericstj approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Starting any URI test leads to a stack overflow in System.Private.CoreLib
6 participants
@ViktorHofer @jkotas @ericstj @safern @karelz @Dotnet-GitSync-Bot