-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CBOR property tests in CI runs #40135
Enable CBOR property tests in CI runs #40135
Conversation
The new tests seem to be triggering a jit assertion failure
|
src/libraries/System.Formats.Cbor/tests/System.Formats.Cbor.Tests.csproj
Outdated
Show resolved
Hide resolved
src/libraries/System.Formats.Cbor/tests/System.Formats.Cbor.Tests.csproj
Outdated
Show resolved
Hide resolved
src/libraries/System.Formats.Cbor/tests/System.Formats.Cbor.Tests.csproj
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Eirik
@dotnet/jit-contrib - can someone take a look? |
@eiriktsarpalis - do you mind opening an issue for this? |
Holding off merge until the JIT issue is addressed. |
dc83ff2
to
02f3714
Compare
02f3714
to
8c67f24
Compare
The dotnet-linker failures seem unrelated, merging away. |
* enable cbor property tests in CI runs * address feedback
@ViktorHofer as discussed I've reduced the default number of test runs and enabled the property tests to run by default. The tests use a fixed seed, so they should run deterministically.