Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CBOR property tests in CI runs #40135

Merged

Conversation

eiriktsarpalis
Copy link
Member

@ViktorHofer as discussed I've reduced the default number of test runs and enabled the property tests to run by default. The tests use a fixed seed, so they should run deterministically.

@ghost
Copy link

ghost commented Jul 30, 2020

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq
See info in area-owners.md if you want to be subscribed.

@eiriktsarpalis
Copy link
Member Author

The new tests seem to be triggering a jit assertion failure

Assert failure(PID 82341 [0x000141a5], Thread: 933639 [0xe3f07]): Assertion failed 'tree->AsField()->gtFldObj == nullptr' in 'elems@20:Close():this' during 'Update flow graph early pass' (IL size 133)

    File: /Users/runner/work/1/s/src/coreclr/src/jit/flowgraph.cpp Line: 19214
    Image: /private/tmp/helix/working/A9D5098C/p/dotnet

https://helix.dot.net/api/2019-06-17/jobs/0f1d3237-ffc7-4114-997c-99c6e9a4cf6d/workitems/System.Formats.Cbor.Tests/files/console.18e4f01b.log

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eirik

@kunalspathak
Copy link
Member

The new tests seem to be triggering a jit assertion failure

Assert failure(PID 82341 [0x000141a5], Thread: 933639 [0xe3f07]): Assertion failed 'tree->AsField()->gtFldObj == nullptr' in 'elems@20:Close():this' during 'Update flow graph early pass' (IL size 133)

    File: /Users/runner/work/1/s/src/coreclr/src/jit/flowgraph.cpp Line: 19214
    Image: /private/tmp/helix/working/A9D5098C/p/dotnet

https://helix.dot.net/api/2019-06-17/jobs/0f1d3237-ffc7-4114-997c-99c6e9a4cf6d/workitems/System.Formats.Cbor.Tests/files/console.18e4f01b.log

@dotnet/jit-contrib - can someone take a look?

@kunalspathak
Copy link
Member

@dotnet/jit-contrib - can someone take a look?

@eiriktsarpalis - do you mind opening an issue for this?

@eiriktsarpalis
Copy link
Member Author

Holding off merge until the JIT issue is addressed.

@eiriktsarpalis eiriktsarpalis force-pushed the cbor-enable-ci-propetytests branch from dc83ff2 to 02f3714 Compare August 6, 2020 19:04
@eiriktsarpalis eiriktsarpalis force-pushed the cbor-enable-ci-propetytests branch from 02f3714 to 8c67f24 Compare August 7, 2020 05:23
@eiriktsarpalis
Copy link
Member Author

The dotnet-linker failures seem unrelated, merging away.

@eiriktsarpalis eiriktsarpalis merged commit 56b865a into dotnet:master Aug 7, 2020
@eiriktsarpalis eiriktsarpalis deleted the cbor-enable-ci-propetytests branch August 7, 2020 10:53
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
* enable cbor property tests in CI runs

* address feedback
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants