Do not check static methods for variance safety rules #40152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
approved these changes
Jul 30, 2020
|
@AlekseyTs This is the change you requested. |
|
The mono failures are due to the CopyCtor test I checked in yesterday which shouldn't run on Mono. I've submitted a PR to exclude them from running. The x86 CoreCLR test failures are due to the same test, but shouldn't be failing. I'm investigating this now. |
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
- There are no variance restrictions on the method signature of static members This change brings the coreclr runtime into compliance with section 9.7 of Partition II of the ECMA 335 spec.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings the coreclr runtime into compliance with section 9.7 of Partition II of the ECMA 335 spec.
Fixes #39612