Fix Japanese Abbreviated Era Names #40300
Conversation
| abbrevEnglishEraNames = s_abbreviatedEnglishEraNames; | ||
| } | ||
|
|
||
| if (abbrevEnglishEraNames[abbrevEnglishEraNames.Length - 1].Length != 1 || abbrevEnglishEraNames[abbrevEnglishEraNames.Length - 1][0] > '\u007F') |
There was a problem hiding this comment.
Just to understand this, why would having the Length != 1 of the abbrevEnglishEraNames on the last element or having a character in first position greater than DELETE character is an indicator that we couldn't get the abbreviated english names?
There was a problem hiding this comment.
The Japanese English abbreviated names so far is only one letter. In some versions of ICU versions (e.g. ver 50) it doesn't return these Latin letters. The check here is indicating if we have Latin or non Latin names. The check here is enough. I may remove the length check just in case in the future we'll get more than one letter (which unlikely but it is possible).
There was a problem hiding this comment.
I see, makes sense. Thanks for explaining!
|
ApiCompat failure is: #40416 |
ghost
locked as resolved and limited conversation to collaborators
Fixes #40194