September infra rollout - continued CoreCLR / Mono test cleanup (minimal) #40345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trylek
requested review from
jkoritzinsky,
jashook,
echesakov,
ViktorHofer,
safern,
naricc and
SamMonoRT
|
Tagging subscribers to this area: @ViktorHofer |
|
Hello everyone! As I'm already three days past the originally planned roll-out date and there's been no progress on this review so far, I treat this as an indication that we're not inclined to risk destabilizing testing at this point and this change (and the related work item) should be postponed to the next monthly roll-out on September 7th. Please let me know if you think otherwise. Thanks Tomas |
trylek
force-pushed
the
dev/trylek/AugustTestCleanupMinimal
branch
from
a141889 to
6f4c937
Compare
ViktorHofer
changed the title
trylek
force-pushed
the
dev/trylek/AugustTestCleanupMinimal
branch
from
6f4c937 to
ef04c92
Compare
ViktorHofer
reviewed
Sep 7, 2020
ViktorHofer
reviewed
Sep 7, 2020
ViktorHofer
approved these changes
Sep 7, 2020
|
Merging in as I believe that the CovariantReturn test failures are seen in other outerloop runs and unrelated to my change. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the previous occasion, I have identified this set as the minimum meaningful set of scripts to move without causing too much disruption apart from purely mechanical renames. This change moves the developer-facing test-related CoreCLR scripts under the
src/testsfolder in accordance with the previous move of the tests themselves:src/coreclr/build-test.cmdtosrc/tests/build.cmdsrc/coreclr/build-test.shtosrc/tests/build.shsrc/coreclr/tests/build.projtosrc/tests/build.projsrc/coreclr/tests/runtest.cmdtosrc/tests/run.cmdsrc/coreclr/tests/runtest.shtosrc/tests/run.shsrc/coreclr/tests/src/runtest.projtosrc/tests/run.projsrc/coreclr/tests/issues.targetstosrc/tests/issues.targetsThe rest of the change constitutes mere path adjustments to match the primary rename.
Move of the rest of the
src/coreclr/testsfolder undersrc/testsincluding unification of the variouspropsandtargetsfile that I originally proposed is extremely complicated and most of it doesn't affect normal developers' daily life at all so I believe that at least some of these cleanups can be made out-of-band, not waiting on the monthly infra roll-out cadence.Fixes: #38919
(I'll triage the remaining changes I originally proposed in the work item, I'll send out "normal" PR's for non-disruptive ones and I'll create a new follow-up September roll-out change for the rest.)
Thanks
Tomas
/cc: @dotnet/runtime-infrastructure