Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused locals left assigment in Cryptography.CapiHelper #40477

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Remove unused locals left assigment in Cryptography.CapiHelper #40477

merged 1 commit into from
Aug 10, 2020

Conversation

KimKiHyuk
Copy link
Contributor

@KimKiHyuk KimKiHyuk commented Aug 6, 2020 •
edited
Loading

related issue is #30457

#30457

@ghost
Copy link

ghost commented Aug 6, 2020

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq
See info in area-owners.md if you want to be subscribed.

@dnfadmin
Copy link

dnfadmin commented Aug 6, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@KimKiHyuk KimKiHyuk changed the title Remove unused variables from Cryptography.CapiHelper.Shared.cs Remove unused variables from Cryptography Aug 6, 2020
bartonjs
bartonjs requested changes Aug 6, 2020
View reviewed changes
Copy link
Member

@bartonjs bartonjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the side effecting Read methods need to be restored.

@KimKiHyuk KimKiHyuk force-pushed the del/unusedCrytography branch from 9656b31 to 9b93a90 Compare August 7, 2020 00:18
@KimKiHyuk KimKiHyuk force-pushed the del/unusedCrytography branch from 9b93a90 to a74ed69 Compare August 7, 2020 00:31
@KimKiHyuk KimKiHyuk changed the title Remove unused variables from Cryptography Remove unused locals left assigment in Cryptography.CapiHelper Aug 7, 2020
@KimKiHyuk KimKiHyuk requested a review from bartonjs August 7, 2020 05:29
@KimKiHyuk KimKiHyuk requested a review from danmoseley August 7, 2020 15:00
@KimKiHyuk KimKiHyuk mentioned this pull request Aug 8, 2020
Closed
@KimKiHyuk
Copy link
Contributor Author

@danmosemsft Could you merge it if it is ok? 😄

@bartonjs bartonjs merged commit 93e8e05 into dotnet:master Aug 10, 2020
@KimKiHyuk KimKiHyuk mentioned this pull request Aug 12, 2020
Closed
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bartonjs bartonjs bartonjs approved these changes

@danmoseley danmoseley Awaiting requested review from danmoseley

Assignees
No one assigned
Labels
area-System.Security
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@KimKiHyuk @dnfadmin @danmoseley @bartonjs @karelz @Dotnet-GitSync-Bot