Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetProcessEnvironment command to diagnostics server #40556

Merged
merged 12 commits into from
Aug 14, 2020
Merged

Add GetProcessEnvironment command to diagnostics server #40556

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a8674e5
send environment black without replacing nulls
Aug 7, 2020
5303432
Windows compilation error
Aug 8, 2020
945bdfc
appease MSVC
Aug 8, 2020
eca8062
Note that it is valid to have empty env vals
Aug 8, 2020
8a64ed1
handle env vals with = in them
Aug 8, 2020
e2c4be2
Use IndexOf instead of Split and Join
Aug 8, 2020
dbf5055
Remove dead code from test
Aug 10, 2020
8e3e93e
rename EnsureEnv
Aug 12, 2020
102f207
add more test values
Aug 12, 2020
32e51d4
Split environment into a separate command
Aug 12, 2020
970ef47
memcpy instead of iterating
Aug 12, 2020
d0faccc
Add future value
Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/tests/tracing/eventpipe/processinfo/processinfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ public static int Main(string[] args)
string envKey = "TESTKEY";
string envVal = "TESTVAL";
System.Environment.SetEnvironmentVariable(envKey, envVal);
josalem marked this conversation as resolved.
Show resolved Hide resolved
System.Environment.SetEnvironmentVariable("foo", "");
josalem marked this conversation as resolved.
Show resolved Hide resolved

Stream stream = ConnectionHelper.GetStandardTransport(pid);

Expand Down Expand Up @@ -214,9 +215,8 @@ public static int Main(string[] args)
end = start + ((int)pairLength * sizeof(char));
Utils.Assert(end <= totalSize, $"String end can't exceed payload size. Expected: <{totalSize}, Received: {end} (decoded length: {pairLength})");
string envPair = System.Text.Encoding.Unicode.GetString(response.Payload[start..end]).TrimEnd('\0');
string[] parts = envPair.Split('=');
string value = string.Join('=', parts[1..]);
env[parts[0]] = value;
int equalsIndex = envPair.IndexOf('=');
env[envPair[0..equalsIndex]] = envPair[(equalsIndex+1)..];
}
Logger.logger.Log($"finished parsing env");

Expand Down