[browser] Mark APIs as unsupported on browser #40612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @safern, @ViktorHofer |
safern
reviewed
Aug 10, 2020
MaximLipnin
force-pushed
the
wasm_add_attr_for_unsupported_api
branch
from
27c710e to
d9fe14b
Compare
steveisok
approved these changes
Aug 13, 2020
safern
approved these changes
Aug 13, 2020
|
This is already merged, but tagging @adamsitnik as an FYI. |
|
Very surgical; nice! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the related spec PR is a draft, we could start looking at how to use that new
UnsupportedOSPlatformattribute.APIs marked as unsupported at assembly level in this PR:
RandomNumberGeneratorandRandomNumberGeneratorImplementationclasses so we'll have to mark all the remaining types as unsupportedThe example of the assembly info generated for S.S.C.OpenSsl which contains UnsupportedOSPlatform attributes for windows and browser platforms:
Part of #41087