Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused local #40968

Closed
wants to merge 1 commit into from
Closed

Remove unused local #40968

wants to merge 1 commit into from

Conversation

seonyounggg
Copy link
Contributor

@seonyounggg seonyounggg commented Aug 18, 2020

This fixes a part of #30457
remove unused local variable tempHandle at line 62
Please check it

issue #30457
remove unused local variable tempHandle at line 62
@huoyaoyuan
Copy link
Member

It should be the local to be unused, not the function call. The valid change should be changing the local to discard(_).

Given that the repo hasn't opt-in discard fully in old code, I don't suggest you to do such changes.

@seonyounggg
Copy link
Contributor Author

@huoyaoyuan You mean that Interop.VirtualAlloc(...) should be remained?

@huoyaoyuan
Copy link
Member

@seonyounggg It must be remained because it has side effect out of the runtime.
In my opinion, changing IntPtr tmpHandle to _ is too minor and doesn't worth a PR.

@seonyounggg
Copy link
Contributor Author

Okay then I'll close this. Thanks for replying.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants