Fix mono_wasm_invoke_js_blazor in dotnet_support.js #41058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @lewing \ @kjpou1 \ @marek-safar we're trying to land a feature in 5.0-rc1 that requires this change. This particular method is specifically tied to Blazor, so it should be fairly safe to take it. If you need further details, please feel free to ping either of us and we can fill you in. Given we'd like to get this for rc1, what branch should we be targeting? |
|
@pranavkm - merging in master and backporting to release/5.0 should get it in RC1 |
lewing
approved these changes
Aug 20, 2020
MackinnonBuck
added a commit
to MackinnonBuck/runtime
that referenced
this pull request
Aug 20, 2020
pranavkm
pushed a commit
that referenced
this pull request
Aug 21, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References to
mono_stringinmono_wasm_invoke_js_blazorresulted in aReferenceErrorsincemono_stringwas not defined. This impacted any JS interop calls that threw unhandled exceptions. This fix creates a local variablemono_stringsimilar to how it is done inmono_wasm_invoke_js_marshalled.