Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Mark System.IO.FileSystem.DriveInfo APIs as unsupported on Browser #41328

Closed

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Aug 25, 2020

Contributes to #41087

browser "M:System.IO.DriveInfo.System#Runtime#Serialization#ISerializable#GetObjectData(System.Runtime.Serialization.SerializationInfo,System.Runtime.Serialization.StreamingContext)",System.IO,DriveInfo,"System.Runtime.Serialization.ISerializable.GetObjectData(SerializationInfo, StreamingContext)",0
windows M:System.IO.DriveInfo.set_VolumeLabel(System.String),System.IO,DriveInfo,set_VolumeLabel(String),0

@ghost
Copy link

ghost commented Aug 25, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@@ -19,6 +20,7 @@ public DriveInfo(string driveName)
_name = NormalizeDriveName(driveName);
}

[UnsupportedOSPlatform("browser")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is same as #41085. It does not make sense to be marking serialization infrastructure like this as unsupported. I think this PR can be closed.

@mdh1418 mdh1418 closed this Aug 25, 2020
@mdh1418 mdh1418 deleted the mdhwang/system_io_filesystem_driveinfo branch August 25, 2020 16:01
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.IO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants