Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0] Allow ConnectionListener.AcceptAsync() to return null #41453

Merged
merged 1 commit into from
Aug 28, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Allow return null from ConnectionListener.AcceptAsync
CarnaViire authored and github-actions committed Aug 27, 2020
commit aa0017087d4953c394da3631648812134cb99efe
Original file line number Diff line number Diff line change
@@ -52,7 +52,7 @@ public abstract partial class ConnectionListener : System.IAsyncDisposable, Syst
protected ConnectionListener() { }
public abstract System.Net.Connections.IConnectionProperties ListenerProperties { get; }
public abstract System.Net.EndPoint? LocalEndPoint { get; }
public abstract System.Threading.Tasks.ValueTask<System.Net.Connections.Connection> AcceptAsync(System.Net.Connections.IConnectionProperties? options = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken));
public abstract System.Threading.Tasks.ValueTask<System.Net.Connections.Connection?> AcceptAsync(System.Net.Connections.IConnectionProperties? options = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken));
public void Dispose() { }
protected virtual void Dispose(bool disposing) { }
public System.Threading.Tasks.ValueTask DisposeAsync() { throw null; }
Original file line number Diff line number Diff line change
@@ -27,7 +27,7 @@ public abstract class ConnectionListener : IAsyncDisposable, IDisposable
/// <param name="options">Options used to create the connection, if any.</param>
/// <param name="cancellationToken">A token used to cancel the asynchronous operation.</param>
/// <returns>A <see cref="ValueTask{TResult}"/> for the <see cref="Connection"/>.</returns>
public abstract ValueTask<Connection> AcceptAsync(IConnectionProperties? options = null, CancellationToken cancellationToken = default);
public abstract ValueTask<Connection?> AcceptAsync(IConnectionProperties? options = null, CancellationToken cancellationToken = default);

public void Dispose()
{