Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Net Telemetry style changes #41527

Merged
merged 3 commits into from
Aug 29, 2020
Merged

System.Net Telemetry style changes #41527

merged 3 commits into from
Aug 29, 2020

Conversation

MihaZupan
Copy link
Member

@MihaZupan MihaZupan commented Aug 28, 2020 •
edited
Loading

  • Changed Http11ConnectionEstablished and Http20ConnectionEstablished events to ConnectionEstablished(version)
  • Changed Http11ConnectionClosed and Http20ConnectionClosed events to ConnectionClosed(version)
  • Changed Http11RequestLeftQueue to RequestLeftQueue(version)
  • Added an Http20 equivalent of RequestLeftQueue and added a http20-requests-queue-duration counter
  • Changed System.Net.Security.HandshakeStop event's protocol property from string to SslProtocols enum.

@MihaZupan MihaZupan added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) area-System.Net labels Aug 28, 2020
@MihaZupan MihaZupan added this to the 6.0.0 milestone Aug 28, 2020
@MihaZupan MihaZupan requested review from scalablecory, ManickaP and a team August 28, 2020 18:35
@ghost
Copy link

ghost commented Aug 28, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@MihaZupan
Copy link
Member Author

/azp run runtime-libraries outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

ManickaP
ManickaP approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MihaZupan
Copy link
Member Author

/azp run runtime-libraries outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MihaZupan
Copy link
Member Author

Test failure: #41381

@MihaZupan MihaZupan removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 29, 2020
@MihaZupan MihaZupan merged commit 8e4f937 into dotnet:master Aug 29, 2020
MihaZupan added a commit to MihaZupan/runtime that referenced this pull request Aug 31, 2020
@MihaZupan
System.Net Telemetry style changes (dotnet#41527)
41ffe5d 
* Change HandshakeStop SslProtocols parameter to enum

* Parameterize Http11/Http20 events

* Add dummy request to ensure Http2 settings are received
@MihaZupan MihaZupan mentioned this pull request Aug 31, 2020
Merged
MihaZupan added a commit that referenced this pull request Aug 31, 2020
@MihaZupan @ManickaP
[release/5.0] Http telemetry changes backport (#41610)
6b1b038 
* System.Net Telemetry style changes (#41527)

* Change HandshakeStop SslProtocols parameter to enum

* Parameterize Http11/Http20 events

* Add dummy request to ensure Http2 settings are received

* Moved HTTP request telemetry to HttpClient.SendAsync (#41022)

* Moved HTTP request telemetry to HttpClient.SendAsync

* Added ResponseContent and helper methods events.

* Rework helper method activity nesting

* Expand Telemetry tests

* Also log RequestStart/Stop in HttpMessageInvoker

* Update RequestStart signature

* RequestAborted => RequestFailed rename

* ResponseContent Begin => Start/Stop

* Fix HttpMessageInvoker implementation

* Add Synchronous request Telemetry tests

* Check telemetryStarted before ResponseContentStart

Co-authored-by: MihaZupan <mihazupan.zupan1@gmail.com>

* Add Request/Response Headers/Content Start/Stop events (#41590)

Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ManickaP ManickaP ManickaP approved these changes

@scalablecory scalablecory Awaiting requested review from scalablecory

Assignees
No one assigned
Labels
area-System.Net
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MihaZupan @ManickaP