Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Mark System.Threading.ThreadPoolBoundHandle unsupported on Browser #41884

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Sep 4, 2020

Contributes to #41087

M:System.Threading.ThreadPoolBoundHandle.BindHandle(System.Runtime.InteropServices.SafeHandle),System.Threading,ThreadPoolBoundHandle,BindHandle(SafeHandle),0
M:System.Threading.ThreadPoolBoundHandle.AllocateNativeOverlapped(System.Threading.PreAllocatedOverlapped),System.Threading,ThreadPoolBoundHandle,AllocateNativeOverlapped(PreAllocatedOverlapped),0
M:System.Threading.ThreadPoolBoundHandle.GetNativeOverlappedState(System.Threading.NativeOverlapped*),System.Threading,ThreadPoolBoundHandle,GetNativeOverlappedState(NativeOverlapped*),0
M:System.Threading.ThreadPoolBoundHandle.FreeNativeOverlapped(System.Threading.NativeOverlapped*),System.Threading,ThreadPoolBoundHandle,FreeNativeOverlapped(NativeOverlapped*),0
"M:System.Threading.ThreadPoolBoundHandle.AllocateNativeOverlapped(System.Threading.IOCompletionCallback,System.Object,System.Object)",System.Threading,ThreadPoolBoundHandle,"AllocateNativeOverlapped(IOCompletionCallback, Object, Object)",0

Though Dispose() and Handle were not on the list to mark as unsupported, mark the entire ThreadPoolBoundHandle class as unsupported because the source file ThreadPoolBoundHandle.PlatformNotSupported.cs suggests PNSE.

@ghost
Copy link

ghost commented Sep 4, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@mdh1418
Copy link
Member Author

mdh1418 commented Sep 4, 2020

Turns out System.Threading.Overlapped is windows specific

@mdh1418 mdh1418 closed this Sep 4, 2020
@mdh1418 mdh1418 deleted the mdhwang/system_threading_overlapped_unsupported branch September 4, 2020 19:39
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Threading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants