[release/5.0-rc2] Marking Matrix3x2, Matrix4x4, Plane, and Quaternion as Intrinsic #41885
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #41829 to release/5.0-rc2
/cc @tannergooding
Customer Impact
Customers invoking certain functions on
Matrix3x2
,Matrix4x4
,Plane
, orQuaternion
may see a perf regression due to functions no longer being inlined, the scenario is described in more detail under #41738. Our performance verification runs identified regressions up to 7X on some micro-benchmarks. With the fix, the results are identical to netcoreapp3.1.Testing
The associated benchmark was run with this change to validate the regression was fixed.
Risk
Low. The managed types are merely being annotated as
[Intrinsic]
so that they will get theJitInlineSIMDMultipler
as they did in netcoreapp3.1. The regression was introduced when the types were moved down to System.Private.Corelib which caused the conditions under which they were classified as a SIMD type.