Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0-rc2] Marking Matrix3x2, Matrix4x4, Plane, and Quaternion as Intrinsic #41885

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 4, 2020

Backport of #41829 to release/5.0-rc2

/cc @tannergooding

Customer Impact

Customers invoking certain functions on Matrix3x2, Matrix4x4, Plane, or Quaternion may see a perf regression due to functions no longer being inlined, the scenario is described in more detail under #41738. Our performance verification runs identified regressions up to 7X on some micro-benchmarks. With the fix, the results are identical to netcoreapp3.1.

Testing

The associated benchmark was run with this change to validate the regression was fixed.

Risk

Low. The managed types are merely being annotated as [Intrinsic] so that they will get the JitInlineSIMDMultipler as they did in netcoreapp3.1. The regression was introduced when the types were moved down to System.Private.Corelib which caused the conditions under which they were classified as a SIMD type.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 4, 2020
@tannergooding tannergooding added the Servicing-consider Issue for next servicing release review label Sep 4, 2020
@tannergooding
Copy link
Member

CC. @jeffhandley, please let me know if anything else is required.

@jeffschwMSFT jeffschwMSFT added area-System.Numerics and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Sep 4, 2020
@ghost
Copy link

ghost commented Sep 4, 2020

Tagging subscribers to this area: @tannergooding, @pgovind
See info in area-owners.md if you want to be subscribed.

@jeffhandley jeffhandley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 4, 2020
@ghost
Copy link

ghost commented Sep 4, 2020

Hello @tannergooding!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Sep 5, 2020

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. DotNet Maestro - Int
  2. DotNet Maestro
  3. Dependabot

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@tannergooding tannergooding merged commit a916def into release/5.0-rc2 Sep 5, 2020
@jkotas jkotas deleted the backport/pr-41829-to-release/5.0-rc2 branch September 8, 2020 20:51
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Numerics Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants