Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Mark System.Threading APIs as unsupported on Browser #41888

Closed

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Sep 4, 2020

Contributes towards #41087

"M:System.Threading.EventWaitHandle.#ctor(System.Boolean,System.Threading.EventResetMode)",System.Threading,EventWaitHandle,".ctor(Boolean, EventResetMode)",2
"M:System.Threading.EventWaitHandle.TryOpenExisting(System.String,System.Threading.EventWaitHandle@)",System.Threading,EventWaitHandle,"TryOpenExisting(String, EventWaitHandle)",1
"M:System.Threading.EventWaitHandle.#ctor(System.Boolean,System.Threading.EventResetMode,System.String)",System.Threading,EventWaitHandle,".ctor(Boolean, EventResetMode, String)",2
"M:System.Threading.EventWaitHandle.#ctor(System.Boolean,System.Threading.EventResetMode,System.String,System.Boolean@)",System.Threading,EventWaitHandle,".ctor(Boolean, EventResetMode, String, Boolean)",1
M:System.Threading.EventWaitHandle.OpenExisting(System.String),System.Threading,EventWaitHandle,OpenExisting(String),1
M:System.Threading.AutoResetEvent.#ctor(System.Boolean),System.Threading,AutoResetEvent,.ctor(Boolean),3
"M:System.Threading.ExecutionContext.GetObjectData(System.Runtime.Serialization.SerializationInfo,System.Runtime.Serialization.StreamingContext)",System.Threading,ExecutionContext,"GetObjectData(SerializationInfo, StreamingContext)",0
M:System.Threading.ManualResetEvent.#ctor(System.Boolean),System.Threading,ManualResetEvent,.ctor(Boolean),3

Marked EventWaitHandle, AutoResetEvent, and ManualResetEvent at class level
Omitted ExecutionContext.GetObjectData as it pertains to Serialization infrastructure

@ghost
Copy link

ghost commented Sep 4, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@mdh1418 mdh1418 changed the title Mdhwang/system threading unsupported [wasm] Mark System.Threading APIs as unsupported on Browser Sep 4, 2020
@akoeplinger
Copy link
Member

akoeplinger commented Sep 4, 2020

These look like false positives. I think the PNSE analyzer got confused by this case which is very uncommon:

if (name != null)
throw new PlatformNotSupportedException(SR.PlatformNotSupported_NamedSynchronizationPrimitives);

@mdh1418
Copy link
Member Author

mdh1418 commented Sep 8, 2020

Closing this PR as the relevant changes (EventWaitHandle, AutoResetEvent, and ManualResetEvent) are likely false positives.

@mdh1418 mdh1418 closed this Sep 8, 2020
@mdh1418 mdh1418 deleted the mdhwang/system_threading_unsupported branch September 8, 2020 14:26
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Threading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants