Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Mark System.Net.SocketAddress APIs unsupported on Browser #41987

Closed
wants to merge 2 commits into from
Closed

[wasm] Mark System.Net.SocketAddress APIs unsupported on Browser #41987

wants to merge 2 commits into from

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Sep 8, 2020

Contributes to #41087

M:System.Net.IPEndPoint.Create(System.Net.SocketAddress),System.Net,IPEndPoint,Create(SocketAddress),3
M:System.Net.SocketAddress.get_Family,System.Net,SocketAddress,get_Family(),2
M:System.Net.SocketAddress.ToString,System.Net,SocketAddress,ToString(),3
M:System.Net.SocketAddress.#ctor(System.Net.Sockets.AddressFamily),System.Net,SocketAddress,.ctor(AddressFamily),3
"M:System.Net.SocketAddress.#ctor(System.Net.Sockets.AddressFamily,System.Int32)",System.Net,SocketAddress,".ctor(AddressFamily, Int32)",2

@mdh1418 mdh1418 added arch-wasm WebAssembly architecture area-System.Net.Sockets labels Sep 8, 2020
@ghost
Copy link

ghost commented Sep 8, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@MaximLipnin MaximLipnin mentioned this pull request Sep 8, 2020
Closed
71 tasks
@MaximLipnin
Copy link
Contributor

Might it be false positive case for System.Net.SocketAddress methods? The related tests seem to pass(e.g. System.Net.Primitives.Functional.Tests.SocketAddressTest.Ctor_AddressFamily_Success)

@mdh1418 mdh1418 closed this Sep 9, 2020
@mdh1418 mdh1418 deleted the mdhwang/system_net_socketaddress branch September 9, 2020 16:18
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
@karelz karelz added this to the 6.0.0 milestone Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@MaximLipnin MaximLipnin Awaiting requested review from MaximLipnin

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.Net.Sockets
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mdh1418 @MaximLipnin @karelz