Fix ilasm parsing of defines #42002
Merged
Fix ilasm parsing of defines #42002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression introduced by dotnet#41611 Fixes dotnet#42001
|
cc @am11 |
|
Ah, so this is a case of ANSI string, which we decided not to support / care about in ilasm, but it turned out we do need to support it. |
janvorli
reviewed
Sep 9, 2020
| @@ -924,10 +924,6 @@ int yylex() | |||
| tok = parse_literal(curSym, curPos, FALSE); | |||
| if(tok == QSTRING) | |||
| { | |||
| // insert UTF-8 BOM prefix | |||
There was a problem hiding this comment.
Will strings encoded in UTF-8 still work?
There was a problem hiding this comment.
I was not able to figure out what this was supposed to help with. Non-ASCII QSTRINGs (quoted strings) never worked in this position as far as I can tell. The following:
#define NAME "ššš"
.assembly NAME
fails in all .NET Framework and earlier .NET Core versions of ilasm. The case that this change is fixing is:
#define NAME "sss"
.assembly NAME
janvorli
approved these changes
Sep 9, 2020
|
Are we going to backport it to RC2? or Will this be .NET6 fix? |
|
This is .NET 6 only regression. No backporting necessary. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced by #41611
Fixes #42001