-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark System.Runtime APIs Supported on Windows #42030
Mark System.Runtime APIs Supported on Windows #42030
Conversation
The remaining methods seem like false-positives, but I wasn't sure. @MaximLipnin @steveisok could y'all take a look? |
Agree. |
It may make sense to mark these as Windows-specific. |
Both runtime/src/libraries/System.Private.CoreLib/src/System/Globalization/Normalization.Icu.cs Line 104 in 8fc68f6
Since the method is partially supported, and there's currently no solution to mark this for the compatibility analyzer, the two APIs will not be marked as unsupported |
d4a9a12
to
bcd79f0
Compare
Of the APIs listed to be marked as unsupported, many were serialization related (had
System.Runtime.Serialization.SerializationInfo
as a parameter), throw PNSE everywhere, or throw PNSE on mono.This PR marks
System.Type.GetTypeFromCLSID
andSystem.Type.GetTypeFromProgID
as Supported on Windows only.