Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix System.Net.Sockets telemetry #42188

Merged
merged 28 commits into from
Sep 25, 2020
Merged

Fix System.Net.Sockets telemetry #42188

merged 28 commits into from
Sep 25, 2020

Commits on Sep 10, 2020

  1. Correct NameResolutionTelemetry logic 

    Taken from c4c9a2f99b7e339388199086d3014041abccc21e
    @MihaZupan
    MihaZupan committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    ffbb975 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2020

  1. Enable listening to multiple sources with TestEventListener

    @MihaZupan
    MihaZupan committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    29b9221 View commit details
    Browse the repository at this point in the history

  2. Workaround EventWrittenEventArgs bug when the EventArgs are stored 

    Workaround dotnet#42128
    @MihaZupan
    MihaZupan committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    cf57e18 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. Correct System.Net.Sockets Telemetry

    @MihaZupan
    MihaZupan committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    9b7c93f View commit details
    Browse the repository at this point in the history

  2. Avoid using value tuple in TestEventListener

    @MihaZupan
    MihaZupan committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    5478d2e View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2020

  1. Remove unnecessary argument to OnCompletedInternal

    @MihaZupan
    MihaZupan committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    46443e4 View commit details
    Browse the repository at this point in the history

  2. Remove redundant Telemetry.IsEnabled check

    @MihaZupan
    MihaZupan committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    5d98405 View commit details
    Browse the repository at this point in the history

  3. Log Connect/Accept start before the initial context capture

    @MihaZupan
    MihaZupan committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    b600f04 View commit details
    Browse the repository at this point in the history

  4. Use SocketHelperBase in Accept tests

    @MihaZupan
    MihaZupan committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    9a94dab View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2020

  1. Avoid duplicate events for BeginConnect without ConnextEx support

    @MihaZupan
    MihaZupan committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    eb9220d View commit details
    Browse the repository at this point in the history

  2. Enable Sync Socket tests

    @MihaZupan
    MihaZupan committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    bb4ae17 View commit details
    Browse the repository at this point in the history

  3. Revert unrelated SocketPal change

    @MihaZupan
    MihaZupan committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    c315bc2 View commit details
    Browse the repository at this point in the history

  4. Log the correct ErrorCode in case of socket disposal

    @MihaZupan
    MihaZupan committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    2f62c7f View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2020

  1. Add more info on TelemetryTest timeout

    @MihaZupan
    MihaZupan committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    c7378a9 View commit details
    Browse the repository at this point in the history

  2. Add PlatformSpecific attribute to ConnectFailure test

    @MihaZupan
    MihaZupan committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    1f8530c View commit details
    Browse the repository at this point in the history

  3. Add missing BeginConnect AfterConnect call on sync failure

    @MihaZupan
    MihaZupan committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    3cf6220 View commit details
    Browse the repository at this point in the history

  4. Add comment around GetHelperBase

    @MihaZupan
    MihaZupan committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    13480c2 View commit details
    Browse the repository at this point in the history

  5. Correct WaitForEventCountersAsync helper

    @MihaZupan
    MihaZupan committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    ce797ac View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. Assert against SocketError.TimedOut in ConnectFailed test

    @MihaZupan
    MihaZupan committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    6120452 View commit details
    Browse the repository at this point in the history

  2. Add EndConnect comment

    @MihaZupan
    MihaZupan committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    4d0289f View commit details
    Browse the repository at this point in the history

  3. Log Failure around sync SocketPal exceptions

    @MihaZupan
    MihaZupan committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    3dd524e View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. Don't assert that the exception message is empty

    @MihaZupan
    MihaZupan committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    fabbea7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into telem-fixes

    @MihaZupan
    MihaZupan committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    00e396e View commit details
    Browse the repository at this point in the history

  3. Dispose socket in a different Thread

    @MihaZupan
    MihaZupan committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    2ac2bc7 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Disable Telemetry failure tests for Sync on RedHat7

    @MihaZupan
    MihaZupan committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    d0d849f View commit details
    Browse the repository at this point in the history

  2. Use more descriptive names in MemberData generation

    @MihaZupan
    MihaZupan committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    1b9d10a View commit details
    Browse the repository at this point in the history

  3. Avoid using reflection for dotnet#42128 workaround

    @MihaZupan
    MihaZupan committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    a39d49b View commit details
    Browse the repository at this point in the history

  4. Remove ConnectCanceled event

    @MihaZupan
    MihaZupan committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    35b9564 View commit details
    Browse the repository at this point in the history