[release/5.0-rc2] Fix the globalization test. #42226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The failure is because Windows regresion. The change here is to avoid having the test fail because of that. The regression is tracked by Windows team to fix it.
|
OK to merge this test-only stability change as "tell mode" |
safern
approved these changes
Sep 15, 2020
stephentoub
reviewed
Sep 15, 2020
| private static extern int CompareStringEx(string lpLocaleName, uint dwCmpFlags, string lpString1, int cchCount1, string lpString2, int cchCount2, IntPtr lpVersionInformation, IntPtr lpReserved, int lParam); | ||
| private const int NORM_LINGUISTIC_CASING = 0x08000000; // use linguistic rules for casing | ||
|
|
||
| private static bool WindowsVersionHasTheCompareStringRegression => |
There was a problem hiding this comment.
What does "the compare string regression" mean? Will we understand which regression it's referring to in a month or a year?
There was a problem hiding this comment.
The code is clear I guess. comparing 2 specific strings returning wrong results. I expect we'll remove this code when Windows fix the regression too. I added this code as I don't know specific versions will have the regression and when it is going to be fixed.
There was a problem hiding this comment.
@stephentoub please let me know if you have any concern before I merge this one.
There was a problem hiding this comment.
Might be worth a comment, but otherwise, ok.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #42212 to release/5.0-rc2
/cc @tarekgh
Customer Impact
This is a test only change. No product change. So, there is no real customer impact more than developers who build and run our tests against the release branch.
The change here is avoiding the test failure caused by a Windows regression in the new Windows insider builds.
Testing
Running the failed test successfully with no failures.
Risk
None as this is a test change.