Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct perf-send-to-helix on windows #42235

Merged
merged 9 commits into from
Sep 17, 2020
Merged

correct perf-send-to-helix on windows #42235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
591589a
correct perf helix workitems on windows
ooooolivia Sep 15, 2020
877ec4f
Will Revert: turn on PR validation
ooooolivia Sep 15, 2020
6900498
change Agent.Os to runtime var
ooooolivia Sep 15, 2020
09a9e68
remove sendparams condition
ooooolivia Sep 15, 2020
3d560c4
test if macro syntax var case sensitive
ooooolivia Sep 15, 2020
ee64f7b
try expression for Agent.Os
ooooolivia Sep 15, 2020
d81fab5
try $(Agent.Os)
ooooolivia Sep 16, 2020
7549f92
pass osGroup param
ooooolivia Sep 16, 2020
b93364e
revert pr trigger:
ooooolivia Sep 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion eng/common/templates/steps/perf-send-to-helix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,13 @@ parameters:
DisplayNamePrefix: 'Send job to Helix' # optional -- rename the beginning of the displayName of the steps in AzDO
condition: succeeded() # optional -- condition for step to execute; defaults to succeeded()
continueOnError: false # optional -- determines whether to continue the build if the step errors; defaults to false
osGroup: '' # required -- operating system for the job


steps:
- template: /eng/pipelines/common/templates/runtimes/send-to-helix-inner-step.yml
parameters:
osGroup: ${{ variables['Agent.Os'] }}
osGroup: ${{ parameters.osGroup }}
sendParams: $(Build.SourcesDirectory)/eng/common/performance/${{ parameters.ProjectFile }} /restore /t:Test /bl:$(Build.SourcesDirectory)/artifacts/log/$(_BuildConfig)/SendToHelix.binlog
trylek marked this conversation as resolved.
Show resolved Hide resolved
displayName: ${{ parameters.DisplayNamePrefix }}
condition: ${{ parameters.condition }}
Expand Down
1 change: 1 addition & 0 deletions eng/pipelines/coreclr/templates/run-performance-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ jobs:
WorkItemDirectory: '$(WorkItemDirectory)' # WorkItemDirectory can not be empty, so we send it some docs to keep it happy
CorrelationPayloadDirectory: '$(PayloadDirectory)' # it gets checked out to a folder with shorter path than WorkItemDirectory so we can avoid file name too long exceptions
ProjectFile: ${{ parameters.projectFile }}
osGroup: ${{ parameters.osGroup }}
- task: PublishPipelineArtifact@1
displayName: Publish Logs
inputs:
Expand Down
1 change: 1 addition & 0 deletions eng/pipelines/coreclr/templates/run-scenarios-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ jobs:
WorkItemDirectory: '$(WorkItemDirectory)' # contains scenario tools, shared python scripts, dotnet tool
CorrelationPayloadDirectory: '$(PayloadDirectory)' # contains performance repo and built product
ProjectFile: ${{ parameters.projectFile }}
osGroup: ${{ parameters.osGroup }}

# publish logs
- task: PublishPipelineArtifact@1
Expand Down