Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark some APIs throwing PNSE from runtime as unsupported on Browser #42310

Merged
merged 3 commits into from
Sep 22, 2020
Merged

Mark some APIs throwing PNSE from runtime as unsupported on Browser #42310

merged 3 commits into from
Sep 22, 2020

Conversation

MaximLipnin
Copy link
Contributor

@MaximLipnin MaximLipnin commented Sep 16, 2020 •
edited
Loading

@ghost
Copy link

ghost commented Sep 16, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@MaximLipnin MaximLipnin marked this pull request as ready for review September 22, 2020 11:33
@steveisok steveisok merged commit a5faa95 into dotnet:master Sep 22, 2020
jeffhandley
jeffhandley reviewed Sep 22, 2020
View reviewed changes
Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge review: LGTM

@MaximLipnin MaximLipnin deleted the mark_apis_throwing_pnse_from_runtime branch September 23, 2020 07:24
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffhandley jeffhandley jeffhandley left review comments

@safern safern safern approved these changes

@steveisok steveisok steveisok approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@mdh1418 mdh1418 Awaiting requested review from mdh1418

@lewing lewing Awaiting requested review from lewing

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@EgorBo EgorBo Awaiting requested review from EgorBo

@vargaz vargaz Awaiting requested review from vargaz

Assignees
No one assigned
Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MaximLipnin @steveisok @jeffhandley @safern @Dotnet-GitSync-Bot