Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test perf-send-to-helix syntax #42332

Closed
wants to merge 9 commits into from
Closed

Test perf-send-to-helix syntax #42332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
591589a
correct perf helix workitems on windows
ooooolivia Sep 15, 2020
877ec4f
Will Revert: turn on PR validation
ooooolivia Sep 15, 2020
6900498
change Agent.Os to runtime var
ooooolivia Sep 15, 2020
09a9e68
remove sendparams condition
ooooolivia Sep 15, 2020
3d560c4
test if macro syntax var case sensitive
ooooolivia Sep 15, 2020
ee64f7b
try expression for Agent.Os
ooooolivia Sep 15, 2020
d81fab5
try $(Agent.Os)
ooooolivia Sep 16, 2020
acc1570
try setting condition
ooooolivia Sep 16, 2020
c8652d1
wip
ooooolivia Sep 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/common/templates/steps/perf-send-to-helix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ parameters:
steps:
- template: /eng/pipelines/common/templates/runtimes/send-to-helix-inner-step.yml
parameters:
osGroup: ${{ variables['Agent.Os'] }}
osGroup: variables['Agent.Os']
sendParams: $(Build.SourcesDirectory)/eng/common/performance/${{ parameters.ProjectFile }} /restore /t:Test /bl:$(Build.SourcesDirectory)/artifacts/log/$(_BuildConfig)/SendToHelix.binlog
displayName: ${{ parameters.DisplayNamePrefix }}
condition: ${{ parameters.condition }}
Expand Down
30 changes: 14 additions & 16 deletions eng/pipelines/common/templates/runtimes/send-to-helix-inner-step.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,28 +7,26 @@ parameters:
environment: {}

steps:
- ${{ if eq(parameters.osGroup, 'Windows_NT') }}:
# TODO: Remove and consolidate this when we move to arcade via init-tools.cmd.
- powershell: $(Build.SourcesDirectory)\eng\common\build.ps1 -ci ${{ parameters.restoreParams }}
displayName: Restore blob feed tasks (Windows)
condition: ${{ and(ne(parameters.condition, false), ne(parameters.restoreParams, '')) }}
condition: and(and(ne(${{ parameters.condition }}, false), ne(${{ parameters.restoreParams }}, '')), eq(${{ parameters.osGroup }}, 'Windows_NT'))

- powershell: $(Build.SourcesDirectory)\eng\common\msbuild.ps1 -ci ${{ parameters.sendParams }}
displayName: ${{ parameters.displayName }} (Windows)
condition: ${{ and(ne(parameters.condition, false), ne(parameters.sendParams, '')) }}
condition: and(and(ne(${{ parameters.condition }}, false), ne(${{ parameters.sendParams }}, '')), eq(${{ parameters.osGroup }}, 'Windows_NT'))
env: ${{ parameters.environment }}

- ${{ if ne(parameters.osGroup, 'Windows_NT') }}:
# TODO: Remove and consolidate this when we move to arcade via init-tools.sh.
- script: $(Build.SourcesDirectory)/eng/common/build.sh --ci ${{ parameters.restoreParams }}
displayName: Restore blob feed tasks (Unix)
condition: ${{ and(ne(parameters.condition, false), ne(parameters.restoreParams, '')) }}
${{ if eq(parameters.osGroup, 'FreeBSD') }}:
env:
# Arcade uses this SDK instead of trying to restore one.
DotNetCoreSdkDir: /usr/local/dotnet
# # TODO: Remove and consolidate this when we move to arcade via init-tools.sh.
# - script: $(Build.SourcesDirectory)/eng/common/build.sh --ci ${{ parameters.restoreParams }}
# displayName: Restore blob feed tasks (Unix)
# condition: ${{ and(ne(parameters.condition, false), ne(parameters.restoreParams, '')) }}
# ${{ if eq(parameters.osGroup, 'FreeBSD') }}:
# env:
# # Arcade uses this SDK instead of trying to restore one.
# DotNetCoreSdkDir: /usr/local/dotnet

- script: $(Build.SourcesDirectory)/eng/common/msbuild.sh --ci ${{ parameters.sendParams }}
displayName: ${{ parameters.displayName }} (Unix)
condition: ${{ and(ne(parameters.condition, false), ne(parameters.sendParams, '')) }}
env: ${{ parameters.environment }}
# - script: $(Build.SourcesDirectory)/eng/common/msbuild.sh --ci ${{ parameters.sendParams }}
# displayName: ${{ parameters.displayName }} (Unix)
# condition: ${{ and(ne(parameters.condition, false), ne(parameters.sendParams, '')) }}
# env: ${{ parameters.environment }}
19 changes: 18 additions & 1 deletion eng/pipelines/coreclr/perf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,24 @@ trigger:
- SECURITY.md
- THIRD-PARTY-NOTICES.TXT

pr: none
pr:
branches:
include:
- master
paths:
include:
- '*'
- src/libraries/System.Private.CoreLib/*
exclude:
- .github/*
- docs/*
- CODE-OF-CONDUCT.md
- CONTRIBUTING.md
- LICENSE.TXT
- PATENTS.TXT
- README.md
- SECURITY.md
- THIRD-PARTY-NOTICES.TXT

jobs:
#
Expand Down