Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print help for -? and /? cross-plat #42396

Merged
merged 3 commits into from
Sep 24, 2020

Conversation

ViktorHofer
Copy link
Member

Fixes #42395

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ViktorHofer

build.cmd Show resolved Hide resolved
@ivdiazsa
Copy link
Contributor

ivdiazsa commented Sep 17, 2020

While trying to reproduce this issue, I found something interesting in build.ps1, in the following code snippet:

if ($help -or (($null -ne $properties) -and ($properties.Contains('/help') -or $properties.Contains('/?')))) {
  Get-Help
  exit 0
}

The $properties value is always empty in this clause, so we might as well remove those checks, and stay only with the $help one.

@ivdiazsa
Copy link
Contributor

This was an accident. Pinged Dan to approve the PR again.

@ViktorHofer
Copy link
Member Author

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer ViktorHofer merged commit ae6744a into dotnet:master Sep 24, 2020
@ViktorHofer ViktorHofer deleted the PrintHelpForMoreIdentifiers branch September 24, 2020 12:27
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build.cmd /? at the root just dumps a list of subsets and errors.
4 participants