Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jit preparation for arm64 apple: Use bytes in fgArgTabEntry. #42503

Merged
merged 10 commits into from
Oct 1, 2020
Merged

Jit preparation for arm64 apple: Use bytes in fgArgTabEntry. #42503

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d888195
fix a dumping error introduced in my recent ref PR.
Sep 21, 2020
5f5e631
add a pinvoke test with many small stack arguments.
Aug 26, 2020
345d355
Add get/set for lclVar::lvStkOffs.
Sep 20, 2020
20fdade
Change some types from `size_t` to `unsigned` when working with stack…
Sep 24, 2020
80beef0
Rename `stackSize` to `GetStackSize`.
Sep 22, 2020
49ed384
Do not run stack level setter for arm64 apple.
Sep 24, 2020
1ca1a42
Use bytes in `fgArgTabEntry`.
Sep 20, 2020
3543112
fix comments/rename vars.
Sep 30, 2020
aec6b3a
Add en explanation about `GetStackSlotsNumber`.
Sep 30, 2020
e674e5a
Rename `DEBUG_NOT_OSX_ARM64` to `DEBUG_ARG_SLOTS`.
Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/coreclr/src/jit/compiler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1613,7 +1613,8 @@ struct fgArgTabEntry
return 0;
}

unsigned stackSize() const
// Get the number of bytes that this argument is occyping on the stack.
sandreenko marked this conversation as resolved.
Show resolved Hide resolved
unsigned GetStackSize() const
{
return (TARGET_POINTER_SIZE * this->numSlots);
}
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/src/jit/morph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6695,7 +6695,7 @@ bool Compiler::fgCanFastTailCall(GenTreeCall* callee, const char** failReason)
{
fgArgTabEntry* arg = argInfo->GetArgEntry(index, false);

calleeArgStackSize += arg->stackSize();
calleeArgStackSize += arg->GetStackSize();
}

auto reportFastTailCallDecision = [&](const char* thisFailReason) {
Expand Down