Test Enhancement: Retry entire test for X509 TimeoutTests #42680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TimeoutTests had functionality to retry the X509Chain.Build call if it failed to improve the reliability of the tests. However, retrying only the Build portion broke some assumptions about how long a chain build would take. If Build is invoked for a second time per the retry, however the previous call to Build primed some of the AIA or CRL/OCSP caches, this broke the assumption of how long a delayed fetch would take. Instead, retry the entire test with a new chain every time so that nothing is in the cache and the timing assumptions remain valid.
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @jeffhandley |
bartonjs
approved these changes
Sep 24, 2020
|
Test failures are in |
|
/azp run runtime-libraries outerloop |
|
No pipelines are associated with this pull request. |
|
/azp list |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
None of the outerloop failures were in |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TimeoutTests had functionality to retry the X509Chain.Build call if
it failed to improve the reliability of the tests. However, retrying
only the Build portion broke some assumptions about how long a chain
build would take.
If Build is invoked for a second time per the retry, however the
previous call to Build primed some of the AIA or CRL/OCSP caches, this
broke the assumption of how long a delayed fetch would take.
Instead, retry the entire test with a new chain every time so that
nothing is in the cache and the timing assumptions remain valid.
Closes #42516