Adjust for roslyn change on ref parameters and NotNullIfNotNull #42707
Conversation
src/coreclr/src/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.CoreCLR.cs
Show resolved
Hide resolved
|
@danmosemsft, assuming we're going to take an updated compiler into the release branch for .NET 5, we'll need this change, plus whatever change addresses the unmanaged callers updates @jcouv mentions. |
|
@jeffschw where did we land on compiler updates? I think we have a principle that we build release with release so we must keep taking updates? Any matching fixes would likely be tell mode. |
There was some related discussion about it in this thread for SDK 3.1 release, still using beta version of csc: dotnet/installer#5857. |
|
@stephentoub I'm not sure the approval policy for |
|
Thanks, @jcouv. |
|
I noticed @ViktorHofer did #42269 which I guess (?) means we will continue to get new compilers. @ViktorHofer FYI that this change will need to get into 5.0 when that happens. BTW, is there an |
Depends on if Arcade will continue to update the compiler in their release/5.x branch (which doesn't exist yet).
|
if not necessary for 5.0 RTW, we could/should port this into 5.0 for servicing readiness. |
* Adjust for roslyn change on ref parameters * Adjust for roslyn change on NotNullIfNotNull
* Update dependencies from https://github.com/dotnet/arcade build 20201006.7 Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.ApiCompat From Version 5.0.0-beta.20474.4 -> To Version 5.0.0-beta.20506.7 * React to TargetFramework.Sdk change * Roslyn update response (#43056) * Update function pointer syntax usage to official. * Fix warnings with new Roslyn Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Adjust for roslyn change on ref parameters and NotNullIfNotNull (#42707) * Adjust for roslyn change on ref parameters * Adjust for roslyn change on NotNullIfNotNull * Fix all configurations build Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> Co-authored-by: Aaron Robinson <arobins@microsoft.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: Julien Couvreur <jcouv@users.noreply.github.com> Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Roslyn now uses the R-value/flow-state for
refparameters, instead of the declared type (L-value). (PR dotnet/roslyn#47952)This affected call to
EnsureInitializedCore, which now needs explicit type parmaeters.Roslyn now enforced
NotNullIfNotNullattribute within method bodies. This affectedCreateWrapperOfType, which now needs a suppression.Fixes
D:\repos\runtime\src\coreclr\src\System.Private.CoreLib\src\System\Runtime\InteropServices\Marshal.CoreCLR.cs(592,13): error CS8825: Return value must be non-null because parameter 'o' is non-null. [D:\repos\runtime\src\coreclr\src\System.Private.CoreLib\System.Private.CoreLib.csproj]FYI, more fixes will be need to integrate a new version of roslyn, mostly due to
UnmanagedCallersOnly: