Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not call RemoteCertificateValidationCallback on the same certificate again #42836

Merged
merged 4 commits into from
Sep 30, 2020
Merged

do not call RemoteCertificateValidationCallback on the same certificate again #42836

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a2492b
do not call RemoteCertificateValidationCallback on the same certifica…
wfurt Sep 29, 2020
3742b5d
feedback from review
wfurt Sep 30, 2020
833e55b
feedback from review
wfurt Sep 30, 2020
fea66b1
make sure we do not use Linq
wfurt Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Security/src/System/Net/Security/SecureChannel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,7 +958,7 @@ internal bool VerifyRemoteCertificate(RemoteCertificateValidationCallback? remot
X509Certificate2? certificate = CertificateValidationPal.GetRemoteCertificate(_securityContext, out remoteCertificateStore);

if (_remoteCertificate != null && certificate != null &&
Enumerable.SequenceEqual(certificate.RawData, _remoteCertificate.RawData))
certificate.RawData.SequenceEqual(_remoteCertificate.RawData))
wfurt marked this conversation as resolved.
Show resolved Hide resolved
{
// This is renegotiation or TLS 1.3 and the certificate did not change.
// There is no reason to process callback again as we already established trust.
Expand Down