[5.0][browser][http] Set HttpResponseMessage.RequestMessage #42849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 1415c63)
|
Tagging subscribers to this area: @dotnet/ncl |
lewing
added
Servicing-consider
stephentoub
approved these changes
Sep 29, 2020
leecow
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #42822
Customer Impact
Fixes #42691 Sets RequestMessage on the browser response which was unset previously. This is an important part of the response and worth fixing.
Testing
Manually tested.
An explicit test for this case is added in #42844 but we will need a different solution for Browser and any other platform that doesn't support sockets and/or listening for requests.
Risk
Low. This is a one line variable initialization that only impacts browser.