Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullable annotation on ISite.Container #42918

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

stephentoub
Copy link
Member

Fixes #42742

@buyaa-n, I only annotated Container as I'm not convinced Component should be nullable as well. I suggest we wait to see if there's any feedback on it. There's very few implementations / call sites to it / docs about it to go by.

@ghost
Copy link

ghost commented Sep 30, 2020

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@stephentoub stephentoub merged commit 1e15914 into dotnet:master Oct 1, 2020
@stephentoub stephentoub deleted the fixisite branch October 1, 2020 00:58
@stephentoub stephentoub added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Oct 1, 2020
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 1, 2020
@stephentoub
Copy link
Member Author

@jeffhandley, I've marked this as breaking-change. I expect we'll want to have a single list for .NET 6 of all the APIs for which we fixed annotations in a way that could result in more warnings.

@jeffhandley
Copy link
Member

dotnet/docs#21202 was created to aggregate the fixed annotations in 6.0; this API was added to that issue.

@jeffhandley jeffhandley removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 23, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.ComponentModel breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISite.Container nullability annotation does not match the documentation
5 participants