Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'condition: always()' to Disk Usage after Build #44209

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

MattGal
Copy link
Member

@MattGal MattGal commented Nov 3, 2020

Looking at builds like this: https://dev.azure.com/dnceng/public/_build/results?buildId=873478&view=logs&j=1f8f000c-1adc-5434-677a-95dd9e006aba&t=30ef7da5-6e59-540d-0dbe-fa78537a8165&s=d654deb9-056d-50a2-1717-90c08683d50a, the other legs are failing left and right filling the agents' disks. We need to know the disk usage after a build to see if this is relevant to build failures.

Looking at builds like this: https://dev.azure.com/dnceng/public/_build/results?buildId=873478&view=logs&j=1f8f000c-1adc-5434-677a-95dd9e006aba&t=30ef7da5-6e59-540d-0dbe-fa78537a8165&s=d654deb9-056d-50a2-1717-90c08683d50a, the other legs are failing left and right filling the agents' disks.  We need to know the disk usage after a build to see if this is relevant to build failures.
@ghost
Copy link

ghost commented Nov 3, 2020

Hello @MattGal!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Nov 4, 2020

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. DotNet Maestro - Int
  2. DotNet Maestro
  3. Dependabot

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ViktorHofer
Copy link
Member

@maryamariyan the auto-merge bot doesn't work. See message above.

@ViktorHofer ViktorHofer merged commit d8b2120 into master Nov 4, 2020
@ViktorHofer ViktorHofer deleted the MattGal-patch-1 branch November 4, 2020 12:24
@maryamariyan
Copy link
Member

@Anipik do you know who to follow up with for auto-merge?

@Anipik
Copy link
Contributor

Anipik commented Nov 13, 2020

@Anipik do you know who to follow up with for auto-merge?

i can take a look what happened here

@MattGal
Copy link
Member Author

MattGal commented Nov 13, 2020

Having bugged GitHub / AzDO about quite a few issues like this, API calls do get lost especially in heavy load scenarios; typically they get 2-3 retries and are never tried again.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants