You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For projects that require platform support we should use a rid-less
configuration, i.e. $(NetCoreAppCurrent). That guarantees that PNSE
assemblies are available for new configurations that aren't represented
in the defined project's TargetFrameworks. This is especially important
for inbox assemblies.
I left the following assemblies as is as they are partial PNSEs:
System.Security.Cryptography.Algorithms
System.Net.NameResolution
System.Net.Requests and System.Net.WebClient are IL only but
intentionally marked as throwing on Browser.
For projects that require platform support we should use a rid-less
configuration, i.e. $(NetCoreAppCurrent). That guarantees that PNSE
assemblies are available for new configurations that aren't represented
in the defined project's TargetFrameworks. This is especially important
for inbox assemblies.
I left the following assemblies as is as they are partial PNSEs:
- System.Security.Cryptography.Algorithms
- System.Net.NameResolution
System.Net.Requests and System.Net.WebClient are IL only but
intentionally marked as throwing on Browser.
Should we add validation that when the PNSE is set, we check that the tfm is ridless?
This is a bit more complex as we have partial PNSE assemblies now as well with Browser. Also we have PNSE configurations that use a specific implementation ie -Browser but the IL only configuration has the rid-less configuration, i.e. System.Net.WebClient.
This is a bit more complex as we have partial PNSE assemblies now as well with Browser. Also we have PNSE configurations that use a specific implementation ie -Browser but the IL only configuration has the rid-less configuration, i.e. System.Net.WebClient.
Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.
Issue meta data
Issue content:
For projects that require platform support we should use a rid-less
configuration, i.e. $(NetCoreAppCurrent). That guarantees that PNSE
assemblies are available for new configurations that aren't represented
in the defined project's TargetFrameworks. This is especially important
for inbox assemblies.
I left the following assemblies as is as they are partial PNSEs:
System.Security.Cryptography.Algorithms
System.Net.NameResolution
System.Net.Requests and System.Net.WebClient are IL only but
intentionally marked as throwing on Browser.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maryamariyan
added
area-Infrastructure-libraries
and removed
area-Extensions-Configuration
labels
ghost
locked as resolved and limited conversation to collaborators
For projects that require platform support we should use a rid-less
configuration, i.e. $(NetCoreAppCurrent). That guarantees that PNSE
assemblies are available for new configurations that aren't represented
in the defined project's TargetFrameworks. This is especially important
for inbox assemblies.
I left the following assemblies as is as they are partial PNSEs:
System.Net.Requests and System.Net.WebClient are IL only but
intentionally marked as throwing on Browser.
Fixes #44229