Code

Align inner loops#44370

Code

Merged

kunalspathak merged 59 commits intodotnet:masterdotnet/runtime:masterfrom kunalspathak:loopalignmentkunalspathak/runtime:loopalignmentCopy head branch name to clipboardJan 12, 2021

+1,157-135

Commits

Commits on Jan 9, 2021

• Detect inner loop and add 10 bytes of padding at the beginning

  kunalspathak

  committed
  32236ac

• generate nop in previous blocks

  kunalspathak

  committed
  a2ec5d1

• TODO: figure out if anything needs to be done in optCanonicalizeLoop

  kunalspathak

  committed
  89b5812

• Add COMPlus_JitAlignLoopMinBlockWeight and COMPlus_JitAlignLoopMaxCodeSize

  Show description for a84b8be
  kunalspathak

  committed
  a84b8be

• Reuse AlignLoops flag for dynamic loop alignment

  kunalspathak

  committed
  a51759a

• Detect back edge and count no. of instructions before doing loop alignment

  kunalspathak

  committed
  2f57c78

• fix bugs

  kunalspathak

  committed
  b4848f8

• propagate the basic block flag

  kunalspathak

  committed
  fe92c62

• Switch from instrCount to codeSize

  kunalspathak

  committed
  51c3171

• JitAlignLoopWith32BPadding

  kunalspathak

  committed
  0b227a8

• Add emitLoopAlign32Bytes()

  kunalspathak

  committed
  a9c9764

• wip

  kunalspathak

  committed
  7f1f787

• Add logic to avoid emitting nop if not needed

  kunalspathak

  committed
  aac18a4

• fix a condition

  kunalspathak

  committed
  5c3c40e

• Several things:

  Show description for fb91d41
  kunalspathak

  committed
  fb91d41

• Added JitAlignLoopAdaptive algorithm

  kunalspathak

  committed
  0b8eb78

• wip

  kunalspathak

  committed
  072a113

• revert emitarm64.cpp changes

  kunalspathak

  committed
  7e1328a

• fix errors during merge

  kunalspathak

  committed
  d49e84d

• fix build errors

  kunalspathak

  committed
  f6b5135

• refactoring and cleanup

  kunalspathak

  committed
  256aae5

• refactoring and build errors fix

  kunalspathak

  committed
  26c3c84

• jit format

  kunalspathak

  committed
  6bb1a75

• one more build error

  kunalspathak

  committed
  03f6ba6

• Add emitLoopAlignAdjustments()

  kunalspathak

  committed
  8036061

• Update emitLoopAlignAdjustments to just include loopSize calc

  kunalspathak

  committed
  809fc85

• Remove #ifdef ADAPTIVE_LOOP_ALIGNMENT

  kunalspathak

  committed
  5b9b7a0

• Code cleanup

  kunalspathak

  committed
  5584d71

• minor fixes

  kunalspathak

  committed
  f66ee24

• Fix issues:

  Show description for f2f935d
  kunalspathak

  committed
  f2f935d

• Other fixes

  kunalspathak

  committed
  99ea31f

• Remove align_loops flag from coreclr

  kunalspathak

  committed
  8f64963

• Review feedback

  Show description for 1c85c3c
  kunalspathak

  committed
  1c85c3c

• jit format

  kunalspathak

  committed
  ef0b149

• Add FEATURE_LOOP_ALIGN

  kunalspathak

  committed
  599ad43

• remove special case for align

  kunalspathak

  committed
  97fd373

• Do not propagate BBF_LOOP_ALIGN in certain cases

  kunalspathak

  committed
  37b0cdb

• Introduce instrDescAlign and emitLastAlignedIgNum

  kunalspathak

  committed
  c0cc8af

• Several changes:

  Show description for 26f7e61
  kunalspathak

  committed
  26f7e61

• jit format

  kunalspathak

  committed
  305b812

• fix issue related to needLabel

  kunalspathak

  committed
  f8bdfec

• align memory correctly in superpmi

  kunalspathak

  committed
  a205cc0

• Few more fixes:

  Show description for d576e9c
  kunalspathak

  committed
  d576e9c

• minor JITDUMP messages

  kunalspathak

  committed
  28480d1

• Review comments

  kunalspathak

  committed
  bf03842

• missing check

  kunalspathak

  committed
  dae9749

• Mark the last align IG the one that has non-zero padding

  kunalspathak

  committed
  a153742

• More review comments

  kunalspathak

  committed
  ef02fbb

• Propagate BBF_LOOP_ALIGN for compacting blocks

  kunalspathak

  committed
  e7e0d68

• Handle ALIGN_LOOP flag for loops that are unrolled

  kunalspathak

  committed
  4b0e64d

• jit format

  kunalspathak

  committed
  6fddce8

• Loop size upto last back-edge instead of first back-edge

  kunalspathak

  committed
  bad5685

• Take loop weight in consideration

  kunalspathak

  committed
  8c30a96

• remove align flag if loop is no longer valid

  kunalspathak

  committed
  f32f560

• Adjust loop block weight to 4 instead of 8

  kunalspathak

  committed
  23177b0

• missing space after rebase

  kunalspathak

  committed
  9f3cb2d

• fix the enum values after rebase

  kunalspathak

  committed
  74620ed

Commits on Jan 11, 2021

• review feedback

  kunalspathak

  committed
  b100226

Commits on Jan 12, 2021

• Add missing #ifdef DEBUG

  kunalspathak

  committed
  dbeb7d6