Fix R2RDump test in CG2 pipelines #44460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our scripts normally assume that all test projects are at least two nesting levels deep under $(TestBinDir); the r2rdump test was violating that and, in doing so, it was triggering a failure in CG2 compilation. After I decided to fix this by moving the r2rdump folder under "readytorun" I found out that there already is a r2rdump folder there - apparently Amy during her initial R2RDump implementation authored a basic test suite even though it's disabled right now. I have resolved this by moving the original test under "readytorun/r2rdump" to "readytorun/r2rdump/BasicTests" and I moved Andrew's new test under "readytorun/r2rdump/FrameworkTests". I'm not super happy about the naming but I don't have any better ideas at the moment, I'll be happy to improve this based on PR feedback. Thanks Tomas
|
/cc @dotnet/crossgen-contrib |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our scripts normally assume that all test projects are at least
two nesting levels deep under $(TestBinDir); the r2rdump test was
violating that and, in doing so, it was triggering a failure in
CG2 compilation.
After I decided to fix this by moving the r2rdump folder under
"readytorun" I found out that there already is a r2rdump folder
there - apparently Amy during her initial R2RDump implementation
authored a basic test suite even though it's disabled right now.
I have resolved this by moving the original test under
"readytorun/r2rdump" to "readytorun/r2rdump/BasicTests" and I moved
Andrew's new test under "readytorun/r2rdump/FrameworkTests".
I'm not super happy about the naming but I don't have any better
ideas at the moment, I'll be happy to improve this based on PR
feedback.
Thanks
Tomas