Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CancelWaiter assert #44510

Merged
merged 1 commit into from
Nov 11, 2020
Merged

add CancelWaiter assert #44510

merged 1 commit into from
Nov 11, 2020

Conversation

geoffkizer
Copy link
Contributor

stephentoub
stephentoub approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but what led to your adding it? Do you suspect there's a bug in CancellationToken?

@stephentoub stephentoub merged commit 1625da3 into dotnet:master Nov 11, 2020
@geoffkizer
Copy link
Contributor Author

geoffkizer commented Nov 11, 2020 •
edited
Loading

No particular reason. I happened to be playing in that code and it seemed like a good thing to add.

Edit: And the value here I think is not so much to catch CancellationToken bugs, as it is to catch any changes to the value task implementation here that end up using CancelWaiter incorrectly. And to just make the expectation of CancelWaiter self-documented.

@geoffkizer geoffkizer deleted the cancelwaiterassert branch November 11, 2020 17:19
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoffkizer @stephentoub