-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the minimum and target version of the SDK to 5.0.100 #44523
Conversation
The release/5.0 branch will automatically be updated via Arcade to 5.0.100. Updating master as well to be on the same sdk and use the latest released bits instead of a preview version. This also bumps the minimum required version as illink needs a >= 5.0 RC2 SDK anyway.
Tagging subscribers to this area: @ViktorHofer Issue meta data
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Please consider to align the required SDK in global.json with the version shipped with VS whenever possible. It's interesting that not updating global.json will break contribution experience. When VS updates to stable 5.0.100, the build script will start downloading RC2. The source used in dotnet-install script is much slower than VS installer or official downloads. I have to manually install RC2 sdk back to get better building experience. |
@huoyaoyuan we have a strict policy of only updating the SDK once a month during our infrastructure rollout as it is a breaking change. We're going to be merging this on the first day of December, so next week. |
Small correction, first Monday of the month |
Thanks, @ViktorHofer. So then it will not be next week, but the week after, since next Monday is the 30th 😄 |
Closing as this has been done already via a darc auto update. |
Part of December's batched rollout: #44524
The release/5.0 branch will automatically be updated via Arcade to 5.0.100. Updating master as well to be on the same sdk and use the latest released bits instead of a preview version. This also bumps the minimum required version as illink needs a >= 5.0 RC2 SDK anyway.