Drop support for IID_ICorDebugProcess10 and fix thread suspend logic #44549
Conversation
Prevent older VS versions from setting managed data breakpoints.
This is a simplification of dotnet#44539 as proposed by @kouvel
|
Tagging subscribers to this area: @tommcdon Issue meta data
|
| // | ||
| || (CORDebuggerAttached() && | ||
| (g_pDebugInterface->ThreadsAtUnsafePlaces() || g_pDebugInterface->IsSynchronizing())) | ||
| || (CORDebuggerAttached() && g_pDebugInterface->ThreadsAtUnsafePlaces()) |
There was a problem hiding this comment.
This is a simplification of @kouvel's change as proposed in #44539 (comment)
|
@chuckries So going forward: New versions of a debugger will just use the new mechanism for 5.0.1+ and notifications for 3.1 and below, where there is no risk of deadlocks? On older versions 6.0+ will fail the QI so they just can't use DBP, 5.0.0 will potentially deadlock, 5.0.1 should probably also remove the QI to make it possible to just have the behavior in a good state for 5.0.x, and 3.1 work as usual. Is this correct? If so, this PR looks good to me |
|
If an unpatched VS tries to add a data breakpoint to a patched runtime, would it fail? |
|
Oh I see it would look like the patched runtime does not support DBs, think I got it now. LGTM too, thanks! |
…otnet#44549) * Stop providing IID_ICorDebugProcess10 Prevent older VS versions from setting managed data breakpoints. * Simplify the thread collision logic to prevent deadlock This is a simplification of dotnet#44539 as proposed by @kouvel
#44563) * Add ICorDebugHeapValue4 -- CreatePinnedHandle (#44471) * Add ICorDebugHeapValue4 * Add EnableGCNotificationEvents deprecation comment * Drop support for IID_ICorDebugProcess10 and fix thread suspend logic (#44549) * Stop providing IID_ICorDebugProcess10 Prevent older VS versions from setting managed data breakpoints. * Simplify the thread collision logic to prevent deadlock This is a simplification of #44539 as proposed by @kouvel
ghost
locked as resolved and limited conversation to collaborators
See #44539 (comment)